]> git.baikalelectronics.ru Git - kernel.git/commit
bio: return EINTR if copying to user space got interrupted
authorHannes Reinecke <hare@suse.de>
Fri, 12 Feb 2016 08:39:15 +0000 (09:39 +0100)
committerJens Axboe <axboe@fb.com>
Fri, 12 Feb 2016 15:17:41 +0000 (08:17 -0700)
commit33b070da9f652a16a2ebdc3831ebfe36866c2d40
tree56a6454c8f7e68e8244be8ecd90f6208b5ae5315
parent8991e430f3f28c8b8e428306774be67ba7e2b8d8
bio: return EINTR if copying to user space got interrupted

Commit 6c8738f5ee23bf4201bb32cbad01a122ac0eba62 introduced a check for
current->mm to see if we have a user space context and only copies data
if we do. Now if an IO gets interrupted by a signal data isn't copied
into user space any more (as we don't have a user space context) but
user space isn't notified about it.

This patch modifies the behaviour to return -EINTR from bio_uncopy_user()
to notify userland that a signal has interrupted the syscall, otherwise
it could lead to a situation where the caller may get a buffer with
no data returned.

This can be reproduced by issuing SG_IO ioctl()s in one thread while
constantly sending signals to it.

Fixes: 6c8738f [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Cc: stable@vger.kernel.org # v.3.11+
Signed-off-by: Jens Axboe <axboe@fb.com>
block/bio.c