]> git.baikalelectronics.ru Git - kernel.git/commit
drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment
authorVaishali Thakkar <vaishali.thakkar@oracle.com>
Thu, 28 Apr 2016 13:22:49 +0000 (18:52 +0530)
committerRob Clark <robdclark@gmail.com>
Sun, 8 May 2016 14:22:16 +0000 (10:22 -0400)
commit335b8f25e94dbbd9a4aa501a425f1e96cb7d9acd
treecdc28b0bbba63afb866e8f087ef214aa119ba109
parent6a692186088b702519ea79a3b07559a89d90a0eb
drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment

Here, a location is reset to NULL before being passed to PTR_ERR.
So, PTR_ERR should be called before its argument is reassigned
to NULL. Further to simplify things use PTR_ERR_OR_ZERO instead
of PTR_ERR and IS_ERR.

Problem found using Coccinelle.

Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
[fixed fmt string warning (s/%ld/%d/)]
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/edp/edp_ctrl.c