]> git.baikalelectronics.ru Git - kernel.git/commit
Bluetooth: Fix incorrect strncpy() in hidp_setup_hid()
authorAnderson Lizardo <anderson.lizardo@openbossa.org>
Sun, 6 Jan 2013 22:28:53 +0000 (18:28 -0400)
committerGustavo Padovan <gustavo.padovan@collabora.co.uk>
Wed, 9 Jan 2013 19:39:05 +0000 (17:39 -0200)
commit3340a4b406343d3ad3a5d0bdc4c4c55069b0e6c0
tree1a576d1b736c6aba50cb3f7620f3a03de2261c15
parentb136510c240cbeac5a8217f09abe0dc14241a863
Bluetooth: Fix incorrect strncpy() in hidp_setup_hid()

The length parameter should be sizeof(req->name) - 1 because there is no
guarantee that string provided by userspace will contain the trailing
'\0'.

Can be easily reproduced by manually setting req->name to 128 non-zero
bytes prior to ioctl(HIDPCONNADD) and checking the device name setup on
input subsystem:

$ cat /sys/devices/pnp0/00\:04/tty/ttyS0/hci0/hci0\:1/input8/name
AAAAAA[...]AAAAAAAAf0:af:f0:af:f0:af

("f0:af:f0:af:f0:af" is the device bluetooth address, taken from "phys"
field in struct hid_device due to overflow.)

Cc: stable@vger.kernel.org
Signed-off-by: Anderson Lizardo <anderson.lizardo@openbossa.org>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
net/bluetooth/hidp/core.c