]> git.baikalelectronics.ru Git - kernel.git/commit
wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()
authorWei Chen <harperchen1110@gmail.com>
Sun, 26 Mar 2023 05:42:17 +0000 (05:42 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:03:20 +0000 (23:03 +0900)
commit32ffb345d5bd809e22218399a0c86f47d91549d0
tree2e890c434b694c7afc95064b6546d789a8029525
parent2bc87b9a055c2b741fdde3cd5539c71d8d91e191
wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

[ Upstream commit 5dbe1f8eb8c5ac69394400a5b86fd81775e96c43 ]

If there is a failure during copy_from_user or user-provided data buffer is
invalid, rtl_debugfs_set_write_reg should return negative error code instead
of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: cad581290f6d ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230326054217.93492-1-harperchen1110@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtlwifi/debug.c