]> git.baikalelectronics.ru Git - kernel.git/commit
block: fix device_add_disk() kobject_create_and_add() error handling
authorLuis Chamberlain <mcgrof@kernel.org>
Wed, 3 Nov 2021 16:40:23 +0000 (09:40 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 5 Nov 2021 05:21:03 +0000 (23:21 -0600)
commit3210ed1722f5fd3ffc63c0a99a54a5df970155cd
tree710618c7ae9e4141b12e3e1a00251c493e5f748d
parent3518b373a1f61c1ba245fbe66c11b6b4101f1d05
block: fix device_add_disk() kobject_create_and_add() error handling

Commit e5ef66124b7b ("block: add error handling for device_add_disk /
add_disk") added error handling to device_add_disk(), however the goto
label for the kobject_create_and_add() failure did not set the return
value correctly, and so we can end up in a situation where
kobject_create_and_add() fails but we report success.

Fixes: e5ef66124b7b ("block: add error handling for device_add_disk / add_disk")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211103164023.1384821-1-mcgrof@kernel.org
[axboe: fold in followup fix from Wu Bo <wubo40@huawei.com>]
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/genhd.c