]> git.baikalelectronics.ru Git - kernel.git/commit
xhci: Fix null pointer dereference when host dies
authorMathias Nyman <mathias.nyman@linux.intel.com>
Mon, 16 Jan 2023 14:22:12 +0000 (16:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jan 2023 06:24:34 +0000 (07:24 +0100)
commit31f0492093189115620b73735a6592b2d9a77079
tree8a1ae362f11a7f2f7a5d77e9a55d57e034d5bda4
parent0b6aca5adb172489d9a38f1ca39bf0459d9f1cec
xhci: Fix null pointer dereference when host dies

commit 47cb33f79d3470c1709a2a5791daf57e25b7fcaa upstream.

Make sure xhci_free_dev() and xhci_kill_endpoint_urbs() do not race
and cause null pointer dereference when host suddenly dies.

Usb core may call xhci_free_dev() which frees the xhci->devs[slot_id]
virt device at the same time that xhci_kill_endpoint_urbs() tries to
loop through all the device's endpoints, checking if there are any
cancelled urbs left to give back.

hold the xhci spinlock while freeing the virt device

Cc: stable@vger.kernel.org
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20230116142216.1141605-4-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci.c