]> git.baikalelectronics.ru Git - kernel.git/commit
nfs: fix anonymous member initializer build failure with older compilers
authorLinus Torvalds <torvalds@linux-foundation.org>
Sat, 28 May 2016 00:20:27 +0000 (17:20 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 28 May 2016 00:20:27 +0000 (17:20 -0700)
commit31ee2733c53e3a779eebc860bc5b5f779ff2e7df
tree368f2597e554ab9f62c0c11e3a5bb6d191b79c77
parentd1f6afcf6f0c1ca24e9e8e74c9e2cde0ca29adcb
nfs: fix anonymous member initializer build failure with older compilers

Older versions of gcc don't understand named initializers inside a
anonymous structure or union member.  It can be worked around by adding
the bracin gin the initializer for the anonymous member.

Without this, gcc 4.4.4 will fail the build with

    CC      fs/nfs/nfs4state.o
  fs/nfs/nfs4state.c:69: error: unknown field ‘data’ specified in initializer
  fs/nfs/nfs4state.c:69: warning: missing braces around initializer
  fs/nfs/nfs4state.c:69: warning: (near initialization for ‘zero_stateid.<anonymous>.data’)
  make[2]: *** [fs/nfs/nfs4state.o] Error 1

introduced in commit 5243d90c2c7f ("NFSv4: Label stateids with the type")

Reported-and-tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nfs/nfs4state.c