]> git.baikalelectronics.ru Git - kernel.git/commit
inet: frag: enforce memory limits earlier
authorEric Dumazet <edumazet@google.com>
Tue, 31 Jul 2018 03:09:11 +0000 (20:09 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 31 Jul 2018 21:41:29 +0000 (14:41 -0700)
commit318e1b004ee257e161efdbe3ad4783c64407ea6c
tree29f521556a514eab6c303d3974bf0b1773858fac
parentcea4a83812bf3bc9843a552c2f463a683d14aa8a
inet: frag: enforce memory limits earlier

We currently check current frags memory usage only when
a new frag queue is created. This allows attackers to first
consume the memory budget (default : 4 MB) creating thousands
of frag queues, then sending tiny skbs to exceed high_thresh
limit by 2 to 3 order of magnitude.

Note that before commit 19be61be198e ("inet: frags: use rhashtables
for reassembly units"), work queue could be starved under DOS,
getting no cpu cycles.
After commit 19be61be198e, only the per frag queue timer can eventually
remove an incomplete frag queue and its skbs.

Fixes: 62b8ccb703e9 ("inet: frag: move eviction of queues to work queue")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jann Horn <jannh@google.com>
Cc: Florian Westphal <fw@strlen.de>
Cc: Peter Oskolkov <posk@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_fragment.c