]> git.baikalelectronics.ru Git - kernel.git/commit
drm/aspeed: Fix vga_pw sysfs output
authorJoel Stanley <joel@jms.id.au>
Wed, 17 Nov 2021 01:01:45 +0000 (09:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Dec 2021 08:04:47 +0000 (09:04 +0100)
commit316006af1a382aafa0c7f4e840a80c97bb46ed82
tree59ae253716b569ceceb44874a8250580d90e604d
parent65c505498e3fa159678d5ff138bd6c608ecb271e
drm/aspeed: Fix vga_pw sysfs output

[ Upstream commit 3d5bb4ae36097201cecf48b0f04bc21b7d147203 ]

Before the drm driver had support for this file there was a driver that
exposed the contents of the vga password register to userspace. It would
present the entire register instead of interpreting it.

The drm implementation chose to mask of the lower bit, without explaining
why. This breaks the existing userspace, which is looking for 0xa8 in
the lower byte.

Change our implementation to expose the entire register.

Fixes: 52d77a7ee74b ("drm/aspeed: Add sysfs for output settings")
Reported-by: Oskar Senft <osk@google.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
Tested-by: Oskar Senft <osk@google.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20211117010145.297253-1-joel@jms.id.au
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c