]> git.baikalelectronics.ru Git - kernel.git/commit
libbpf: Fix error handling in bpf_map__reuse_fd()
authorToke Høiland-Jørgensen <toke@redhat.com>
Sat, 2 Nov 2019 11:09:37 +0000 (12:09 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 2 Nov 2019 19:35:06 +0000 (12:35 -0700)
commit315e9f9aeeec48c4869a2dde096dbf507f6662a7
tree7907b692db1946516b5930afe570116129d10cd2
parente2982a19a73b81ec5931543b7123b11e5635c8f8
libbpf: Fix error handling in bpf_map__reuse_fd()

bpf_map__reuse_fd() was calling close() in the error path before returning
an error value based on errno. However, close can change errno, so that can
lead to potentially misleading error messages. Instead, explicitly store
errno in the err variable before each goto.

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/157269297769.394725.12634985106772698611.stgit@toke.dk
tools/lib/bpf/libbpf.c