]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Enable voltage swing before enabling DDI_BUF_CTL.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 29 Aug 2017 23:22:26 +0000 (16:22 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 31 Aug 2017 16:30:07 +0000 (09:30 -0700)
commit31186f5d0eb2140cb2ccd39d0da2bb24fa33957f
tree2f62696c1456e162e4391216a3d6d613f98999db
parent8f8b4bb867b5e6ac74a60dc340d41d3ea387446c
drm/i915: Enable voltage swing before enabling DDI_BUF_CTL.

Sequences for DisplayPort asks us to
" Configure voltage swing and related IO settings.
Refer to DDI Buffer section."

before "Configure and enable DDI_BUF_CTL"

On BXT and CNL this means to execute the ddi vswing sequences.

At this point these sequences calls are getting duplicated for DP
because they are all called from DP link trainning sequences.

However this patch is not yet removing it before a futher discussion
since spec also allows that during link training without disabling
anything:

"
Notes
Changing voltage swing during link training:
Change the swing setting following the DDI Buffer section.
The port does not need to be disabled.
"

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170829232230.23051-4-rodrigo.vivi@intel.com
drivers/gpu/drm/i915/intel_ddi.c