]> git.baikalelectronics.ru Git - kernel.git/commit
net: korina: Fix return type of korina_send_packet
authorNathan Huckleberry <nhuck@google.com>
Mon, 12 Sep 2022 21:43:40 +0000 (14:43 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Sep 2022 01:28:50 +0000 (18:28 -0700)
commit300b84306bcf9863af6878dc16d0ed332dca396a
tree7d9874495adf39e2a697e214b0255d42cd60f99c
parent62a31c2da35abe467d32945fde87f53e01e97e1c
net: korina: Fix return type of korina_send_packet

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of korina_send_packet should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220912214344.928925-1-nhuck@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/korina.c