]> git.baikalelectronics.ru Git - kernel.git/commit
firmware: arm_scpi: remove usage of drvdata and don't reset scpi_info to null
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 29 Sep 2017 21:43:54 +0000 (23:43 +0200)
committerSudeep Holla <sudeep.holla@arm.com>
Wed, 4 Oct 2017 10:09:05 +0000 (11:09 +0100)
commit2fc4beba80263c39da2be315cd190f65bce9afc7
tree87178e20e2d0c290b343bc8d767bcd8c392e0876
parent384fde7ed224f283f11ef2a592b05d4a29492aa8
firmware: arm_scpi: remove usage of drvdata and don't reset scpi_info to null

There's no benefit using drvdata as variable scpi_info is global.

Setting scpi_info to NULL in scpi_remove isn't needed too. If arm_scpi
is built-in, then this code is never used. And if arm_scpi is built as
a module and some other module calls get_scpi_ops() then due to this
dependency scpi_remove is called only after the other module has been
removed.

Last but not least, users usually store the result of get_scpi_ops(),
therefore setting scpi_info to NULL wouldn't really help.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
[sudeep.holla: reworded the commit log a bit]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scpi.c