]> git.baikalelectronics.ru Git - kernel.git/commit
wifi: wil6210: debugfs: fix uninitialized variable use in `wil_write_file_wmi()`
authorAmmar Faizi <ammarfaizi2@gnuweeb.org>
Mon, 25 Jul 2022 17:49:11 +0000 (20:49 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 27 Jul 2022 10:20:20 +0000 (13:20 +0300)
commit2fb32e276d1c83d9b11d2c95ead18b5369d82526
tree4503ba2789114f3937a240f96ff2ff19a69d50ec
parentb864a159d1fbb0b18823109276e613aa9908981c
wifi: wil6210: debugfs: fix uninitialized variable use in `wil_write_file_wmi()`

Commit ecc265dbdee4 changes simple_write_to_buffer() with memdup_user()
but it forgets to change the value to be returned that came from
simple_write_to_buffer() call. It results in the following warning:

  warning: variable 'rc' is uninitialized when used here [-Wuninitialized]
           return rc;
                  ^~

Remove rc variable and just return the passed in length if the
memdup_user() succeeds.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: kernel test robot <lkp@intel.com>
Fixes: ecc265dbdee456358679c069cc53e7605f0b432e ("wifi: wil6210: debugfs: fix info leak in wil_write_file_wmi()")
Fixes: 0656f2b3708fcbf3673e00212e6b7169890c4356 ("wil6210: debugfs interface to send raw WMI command")
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220724202452.61846-1-ammar.faizi@intel.com
drivers/net/wireless/ath/wil6210/debugfs.c