]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: disable Split Header (SPH) for Intel platforms
authorTan Tee Min <tee.min.tan@linux.intel.com>
Fri, 29 Apr 2022 11:58:07 +0000 (19:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 May 2022 10:30:05 +0000 (12:30 +0200)
commit2f74092d18f869e28e0a86f449571625ac4f40aa
treeafc3135a78151efc5c49a84c3eff26cbce11ba00
parent7a6fc399e4f7ba2560a3c474ac2a2465c6eb60d3
net: stmmac: disable Split Header (SPH) for Intel platforms

commit 5f15d52a019a9a71b126713ed1de2390c857dbcf upstream.

Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation
of Split Header (SPH) feature is not supported for Ipv4 fragmented packet.
This SPH limitation will cause ping failure when the packets size exceed
the MTU size. For example, the issue happens once the basic ping packet
size is larger than the configured MTU size and the data is lost inside
the fragmented packet, replaced by zeros/corrupted values, and leads to
ping fail.

So, disable the Split Header for Intel platforms.

v2: Add fixes tag in commit message.

Fixes: 3e4d2632676a("net: stmmac: Add Split Header support and enable it in XGMAC cores")
Cc: <stable@vger.kernel.org> # 5.10.x
Suggested-by: Ong, Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
include/linux/stmmac.h