]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: vdso: Wrap -mexplicit-relocs in cc-option
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 17 Feb 2020 21:11:49 +0000 (14:11 -0700)
committerPaul Burton <paulburton@kernel.org>
Wed, 19 Feb 2020 18:30:10 +0000 (10:30 -0800)
commit2f0610b65842580b4d532d1047885df6ac56a7cb
treedf1b5783ff2845b7d9218b11da7788b1653f838c
parent84e765968097256aa1f589d0f3b51584a9a2fe5b
MIPS: vdso: Wrap -mexplicit-relocs in cc-option

Clang does not support this option and errors out:

clang-11: error: unknown argument: '-mexplicit-relocs'

Clang does not appear to need this flag like GCC does because the jalr
check that was added in commit 1c5fa2f7c3d5 ("mips: vdso: add build
time check that no 'jalr t9' calls left") passes just fine with

$ make ARCH=mips CC=clang CROSS_COMPILE=mipsel-linux-gnu- malta_defconfig arch/mips/vdso/

even before commit d9467e2486bb ("mips: vdso: fix 'jalr t9' crash in
vdso code").

-mrelax-pic-calls has been supported since clang 9, which is the
earliest version that could build a working MIPS kernel, and it is the
default for clang so just leave it be.

Fixes: d9467e2486bb ("mips: vdso: fix 'jalr t9' crash in vdso code")
Link: https://github.com/ClangBuiltLinux/linux/issues/890
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: clang-built-linux@googlegroups.com
arch/mips/vdso/Makefile