]> git.baikalelectronics.ru Git - kernel.git/commit
HID: logitech-dj: prevent false errors to be shown
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Fri, 22 Aug 2014 20:16:05 +0000 (16:16 -0400)
committerJiri Kosina <jkosina@suse.cz>
Mon, 25 Aug 2014 07:59:51 +0000 (02:59 -0500)
commit2ef285072ddc22d4dc72dc1d91bfd57804c3ce65
tree56c7163e23cd55f49bbcb128d2bfa60a46aa67d9
parent5fd18a8e3bc910a7ae0be533bacc4e8ede155f43
HID: logitech-dj: prevent false errors to be shown

Commit "HID: logitech: perform bounds checking on device_id early
enough" unfortunately leaks some errors to dmesg which are not real
ones:
- if the report is not a DJ one, then there is not point in checking
  the device_id
- the receiver (index 0) can also receive some notifications which
  can be safely ignored given the current implementation

Move out the test regarding the report_id and also discards
printing errors when the receiver got notified.

Fixes: 3345b355df0e3ad4ab534a28d611b0940504fcbc
Cc: stable@vger.kernel.org
Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-dj.c
drivers/hid/hid-logitech-dj.h