]> git.baikalelectronics.ru Git - kernel.git/commit
procfs: prevent unprivileged processes accessing fdinfo dir
authorKalesh Singh <kaleshsingh@google.com>
Tue, 10 May 2022 00:34:28 +0000 (17:34 -0700)
committerakpm <akpm@linux-foundation.org>
Tue, 10 May 2022 00:34:28 +0000 (17:34 -0700)
commit2d8b7a10006ece0248b8fedc04b4bc1e92354f33
tree7b4c291c5734c549f4d3072b8f117e5f5b27e664
parent72ecc04c9fca670f69f6fab2f759c5646b8670c9
procfs: prevent unprivileged processes accessing fdinfo dir

The file permissions on the fdinfo dir from were changed from
S_IRUSR|S_IXUSR to S_IRUGO|S_IXUGO, and a PTRACE_MODE_READ check was added
for opening the fdinfo files [1].  However, the ptrace permission check
was not added to the directory, allowing anyone to get the open FD numbers
by reading the fdinfo directory.

Add the missing ptrace permission check for opening the fdinfo directory.

[1] https://lkml.kernel.org/r/20210308170651.919148-1-kaleshsingh@google.com

Link: https://lkml.kernel.org/r/20210713162008.1056986-1-kaleshsingh@google.com
Fixes: c8716a0a81eb ("procfs: allow reading fdinfo with PTRACE_MODE_READ")
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Hridya Valsaraju <hridya@google.com>
Cc: Jann Horn <jannh@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/proc/fd.c