]> git.baikalelectronics.ru Git - kernel.git/commit
NFSD: unregister shrinker when nfsd_init_net() fails
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Mon, 10 Oct 2022 05:59:02 +0000 (14:59 +0900)
committerChuck Lever <chuck.lever@oracle.com>
Tue, 11 Oct 2022 14:08:26 +0000 (10:08 -0400)
commit2d80f943a19df74917423b505da5b8f2734dbad5
tree8bc8039109fb10eb154db10f6280c481bbd843dd
parent5ca146dcf1c7fca91a5691639ab12eb0bcdcf63a
NFSD: unregister shrinker when nfsd_init_net() fails

syzbot is reporting UAF read at register_shrinker_prepared() [1], for
commit 0c29c73631803ff3 ("NFSD: add shrinker to reap courtesy clients on
low memory condition") missed that nfsd4_leases_net_shutdown() from
nfsd_exit_net() is called only when nfsd_init_net() succeeded.
If nfsd_init_net() fails due to nfsd_reply_cache_init() failure,
register_shrinker() from nfsd4_init_leases_net() has to be undone
before nfsd_init_net() returns.

Link: https://syzkaller.appspot.com/bug?extid=ff796f04613b4c84ad89
Reported-by: syzbot <syzbot+ff796f04613b4c84ad89@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: 0c29c73631803ff3 ("NFSD: add shrinker to reap courtesy clients on low memory condition")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfsctl.c