]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hda/ca0132: Don't test for QUIRK_NONE
authorAlastair Bridgewater <alastair.bridgewater@gmail.com>
Sat, 16 Jun 2018 01:56:18 +0000 (21:56 -0400)
committerTakashi Iwai <tiwai@suse.de>
Sun, 17 Jun 2018 06:44:55 +0000 (08:44 +0200)
commit2d61e2752a48ccdcf174a278c74015a1df05f1ee
tree810def04305efe7b93cefd47655f2ced83a0f04a
parent6b3d0510a75ce5ab00fa884446b30392e4934b79
ALSA: hda/ca0132: Don't test for QUIRK_NONE

QUIRK_NONE is, quite explicitly, the default case.  The entire
point of a quirks system is to allow "programming by difference"
from a given base case, which requires that merely defining a new
quirk for some piece of hardware should not change the behavior of
the driver for that hardware.  In turn, this means that testing
for QUIRK_NONE explicitly is a violation of that implicit contract.

Change a test for QUIRK_NONE and QUIRK_ALIENWARE to default, and
add a test for QUIRK_SBZ to disable the default behavior in that
instance.

Signed-off-by: Alastair Bridgewater <alastair.bridgewater@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_ca0132.c