]> git.baikalelectronics.ru Git - kernel.git/commit
bluetooth: bpa10x: Replace GFP_ATOMIC with GFP_KERNEL in bpa10x_send_frame()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 23 Jul 2018 03:24:02 +0000 (11:24 +0800)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 23 Jul 2018 16:05:00 +0000 (18:05 +0200)
commit2d22cd00062b870712f4ded8158d5082e10fe54e
treec071e6ad22f0aa82f8e9de7ad1cd96a089e8c144
parenta5bb0f3defa6baffb066717005b6ffcde277fe5b
bluetooth: bpa10x: Replace GFP_ATOMIC with GFP_KERNEL in bpa10x_send_frame()

bpa10x_send_frame() is only set to hdev->send, and hdev->send() is never
called in atomic context.

bpa10x_send_frame() calls usb_alloc_urb(), kmalloc() and usb_submit_urb()
with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/bpa10x.c