]> git.baikalelectronics.ru Git - kernel.git/commit
driver-core: return EINVAL error instead of BUG_ON()
authorFlorian Schmaus <flo@geekplace.eu>
Wed, 23 May 2018 15:59:11 +0000 (17:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 May 2018 16:18:45 +0000 (18:18 +0200)
commit2ca227ce9adb65b55123da507fa2aca07df677fd
treea1f9063eefed025fae2d04257877d4439523bec4
parent42647d085f024381f55d0aaaef4814d1ee92e226
driver-core: return EINVAL error instead of BUG_ON()

I triggerd the BUG_ON() in driver_register() when booting a domU Xen
domain. Since there was no contextual information logged, I needed to
attach kgdb to determine the culprit (the wmi-bmof driver in my
case). The BUG_ON() was added in commit 2879d54e002a ("driver-core: do
not register a driver with bus_type not registered").

Instead of running into a BUG_ON() we print an error message
identifying the, likely faulty, driver but continue booting.

Signed-off-by: Florian Schmaus <flo@geekplace.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/driver.c