]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl: mediatek: move bit assignment
authorLinus Walleij <linus.walleij@linaro.org>
Fri, 28 May 2021 09:13:11 +0000 (11:13 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 28 May 2021 09:19:10 +0000 (11:19 +0200)
commit2c56d26368cab890ee0f4819e29e116aa3c73de9
tree0c81a27ef1579ef4754aa8a31aeda6a141c475dc
parentdf7d93d59b29d551de880b66ee642a5749dff8b5
pinctrl: mediatek: move bit assignment

The bit needs offset to be defined which happens some lines
below. Looks like a bug. The kernel test robot complains:

drivers/pinctrl/mediatek/pinctrl-mtk-common.c:137:12:
warning: variable 'offset' is uninitialized when used here [-Wuninitialized]
           bit = BIT(offset & pctl->devdata->mode_mask);
                     ^~~~~~

Fix it up by reverting to what was done before.

Cc: Fabien Parent <fparent@baylibre.com>
Cc: Sean Wang <sean.wang@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: linux-mediatek@lists.infradead.org
Fixes: 4098b6aea3dd ("pinctrl: mediatek: don't hardcode mode encoding in common code")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mediatek/pinctrl-mtk-common.c