]> git.baikalelectronics.ru Git - kernel.git/commit
platform/surface: aggregator: Fix initialization order when compiling as builtin...
authorMaximilian Luz <luzmaximilian@gmail.com>
Fri, 29 Apr 2022 19:57:38 +0000 (21:57 +0200)
committerHans de Goede <hdegoede@redhat.com>
Fri, 6 May 2022 11:05:57 +0000 (13:05 +0200)
commit2c12ad26ef9479fc279eb86c4c21b209b1cf695a
treea3da85a0b3fb2b8470052cd326258d18252760a5
parentb6fa6046bb202479f13bd77411d17a4fb8574025
platform/surface: aggregator: Fix initialization order when compiling as builtin module

When building the Surface Aggregator Module (SAM) core, registry, and
other SAM client drivers as builtin modules (=y), proper initialization
order is not guaranteed. Due to this, client driver registration
(triggered by device registration in the registry) races against bus
initialization in the core.

If any attempt is made at registering the device driver before the bus
has been initialized (i.e. if bus initialization fails this race) driver
registration will fail with a message similar to:

    Driver surface_battery was unable to register with bus_type surface_aggregator because the bus was not initialized

Switch from module_init() to subsys_initcall() to resolve this issue.
Note that the serdev subsystem uses postcore_initcall() so we are still
able to safely register the serdev device driver for the core.

Fixes: 2ef0797232f5 ("platform/surface: Add Surface Aggregator subsystem")
Reported-by: Blaž Hrastnik <blaz@mxxn.io>
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20220429195738.535751-1-luzmaximilian@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/aggregator/core.c