]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Remove bogus locking check in the hangcheck code
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 3 Feb 2015 10:45:40 +0000 (11:45 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 3 Feb 2015 16:13:04 +0000 (17:13 +0100)
commit2bc9e340648eb193b4ee7409ce12a297c40354bb
treeda8cc18f5ce451d3e5cbfcdb90508f77d903c9e9
parent6b7f606f3da7ee4e26ca7e6d3fa1f6267b1f6217
drm/i915: Remove bogus locking check in the hangcheck code

You can _never_ assert that a lock is not held, except in some very
restricted corner cases where it's guranteed that your code is running
single-threade (e.g. driver load before you've published any pointers
leading to that lock).

In addition the early return breaks a bunch of testcases since with
highly concurrent hangcheck stress tests the reset fails to work and
the test doesn't recover and time out.

This regression has been introduced in

commit 19e57e23790f4805cfa96243e0216cfff0b53b3f
Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Date:   Wed Jan 28 17:03:14 2015 +0200

    drm/i915: Remove nested work in gpu error handling

Aside: It is possible to check whether a given task doesn't hold a
lock, but only when lockdep is enabled, using the lockdep_assert_held
stuff.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88908
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
drivers/gpu/drm/i915/i915_irq.c