]> git.baikalelectronics.ru Git - kernel.git/commit
wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg()
authorWei Chen <harperchen1110@gmail.com>
Sun, 26 Mar 2023 05:31:38 +0000 (05:31 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:03:20 +0000 (23:03 +0900)
commit2bc87b9a055c2b741fdde3cd5539c71d8d91e191
treef31ef4362d84f7d86012bf3e39658c45bbd13ec2
parentdad86691c4e0811861f05f1091110f6b6fa6f4a7
wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg()

[ Upstream commit 905a9241e4e8c15d2c084fee916280514848fe35 ]

If there is a failure during copy_from_user or user-provided data buffer
is invalid, rtl_debugfs_set_write_rfreg should return negative error code
instead of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: cad581290f6d ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230326053138.91338-1-harperchen1110@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtlwifi/debug.c