]> git.baikalelectronics.ru Git - kernel.git/commit
ide-cd: Don't warn on bogus block size unless it actually matters.
authorDavid S. Miller <davem@davemloft.net>
Tue, 23 Jun 2009 23:01:06 +0000 (16:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Jun 2009 07:32:30 +0000 (00:32 -0700)
commit2bb4d3adaf130a3111a322fbfb669b284dbf69d1
tree3c83e7452f6e0ecb14a278ab833626fa3e51a687
parentfad8af7a95f201dad4c06e27267801dcd5c6e8c3
ide-cd: Don't warn on bogus block size unless it actually matters.

Frans Pop reported that his CDROM drive reports a blocksize of 2352,
and this causes new warnings due to commit
c1f61eb6832484f232fa28db1daceac0eeaf2f6e ("ide-cd: fix oops when using
growisofs").

What we're trying to do is make sure that "blocklen >> SECTOR_BITS"
is something the block layer won't choke on.

And for Frans' case "2352 >> SECTOR_BITS" is equal to
"2048 >> SECTOR_BITS", and thats "4".

So warning in this case gives no real benefit.

Reported-by: Frans Pop <elendil@planet.nl>
Tested-by: Frans Pop <elendil@planet.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-cd.c