]> git.baikalelectronics.ru Git - kernel.git/commit
thinkpad-acpi: fix ALSA callback return status
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Sat, 27 Feb 2010 21:45:29 +0000 (18:45 -0300)
committerHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Sat, 27 Feb 2010 21:45:29 +0000 (18:45 -0300)
commit2b8da5e3b82596f176be5c1e337e53ed5b4a15f2
tree317dd539082f7fe26227b1dcf3860433f2e7acfe
parentdd08eff0d401958aa75451b2d64193fd927f62b6
thinkpad-acpi: fix ALSA callback return status

Clemens Ladisch reports that thinkpad-acpi improperly implements the
ALSA API, and always returns 0 for success for the "put" callbacks
while the API requires it to return "1" when the control value has
been changed in the hardware/firmware.

Rework the volume subdriver to be able to properly implement the ALSA
API.  Based on a patch by Clemens Ladisch <clemens@ladisch.de>.

This fix is also needed on 2.6.33.

Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
drivers/platform/x86/thinkpad_acpi.c