]> git.baikalelectronics.ru Git - kernel.git/commit
igb/igc: warn when fatal read failure happens
authorFeng Tang <feng.tang@intel.com>
Wed, 13 Feb 2019 02:41:54 +0000 (10:41 +0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 28 May 2019 22:42:32 +0000 (15:42 -0700)
commit2ace4408318b839bf7fb91234a561f6b3f614db2
treee0eaf8e7310f4abea6b8e46297ed7b52a5dd2cbc
parent52446b2b2aee7c7001d2a90ee2abd343cc8a5be7
igb/igc: warn when fatal read failure happens

Failed in read the HW register is very serious for igb/igc driver,
as its hw_addr will be set to NULL and cause the adapter be seen as
"REMOVED".

We saw the error only a few times in the MTBF test for suspend/resume,
but can hardly get any useful info to debug.

Adding WARN() so that we can get the necessary information about
where and how it happens, and use it for root causing and fixing
this "PCIe link lost issue"

This affects igb, igc.

Signed-off-by: Feng Tang <feng.tang@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igb/igb_main.c
drivers/net/ethernet/intel/igc/igc_main.c