]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: sprd: fix reference leak when pm_runtime_get_sync fails
authorQinglang Miao <miaoqinglang@huawei.com>
Tue, 1 Dec 2020 09:31:44 +0000 (17:31 +0800)
committerWolfram Sang <wsa@kernel.org>
Wed, 14 Apr 2021 07:49:20 +0000 (09:49 +0200)
commit2aafe019c9ff11c04096474f3643cd01b2c5617a
treef1baa4b821820a9169ea80054469063c0869adc4
parent8eb4e1d60b1c92f22e491559095d0e4d3a8f3a81
i2c: sprd: fix reference leak when pm_runtime_get_sync fails

The PM reference count is not expected to be incremented on
return in sprd_i2c_master_xfer() and sprd_i2c_remove().

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: c86185e7ff48 ("i2c: Add Spreadtrum I2C controller driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-sprd.c