]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "media: dvb: Add check on sp8870_readreg"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:25 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 16:32:40 +0000 (18:32 +0200)
commit2aa569a2b0751ab4259e325eb97d79066b08aaae
treedb2652cfebcfc5675e3ee476f2a240accee81f3b
parent49895f910982f78abe4c1bdcac8d34169912c53f
Revert "media: dvb: Add check on sp8870_readreg"

This reverts commit 317bfd32c6cb0798d6f4dad79bb3f68108395ae3.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

This commit is not properly checking for an error at all, so if a
read succeeds from this device, it will error out.

Cc: Aditya Pakki <pakki001@umn.edu>
Cc: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-59-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/dvb-frontends/sp8870.c