]> git.baikalelectronics.ru Git - kernel.git/commit
r8169: remove unneeded memory barrier in rtl_tx
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 29 Oct 2020 17:56:06 +0000 (18:56 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 31 Oct 2020 23:35:49 +0000 (16:35 -0700)
commit2a52546ca15ff5f8a00e86af8d99d8faad3419a2
treeae1f5e03ced0bf1b5a32446a30944ac69818b7f9
parent70a321d6608cbbc0c2d85a3bc7a2943791a8ccbf
r8169: remove unneeded memory barrier in rtl_tx

tp->dirty_tx isn't changed outside rtl_tx(). Therefore I see no need
to guarantee a specific order of reading tp->dirty_tx and tp->cur_tx.
Having said that we can remove the memory barrier.
In addition use READ_ONCE() when reading tp->cur_tx because it can
change in parallel to rtl_tx().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/2264563a-fa9e-11b0-2c42-31bc6b8e2790@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c