]> git.baikalelectronics.ru Git - kernel.git/commit
irqchip/armada-370-xp: Fix ack/eoi breakage
authorMarc Zyngier <maz@kernel.org>
Wed, 22 Sep 2021 13:19:41 +0000 (14:19 +0100)
committerMarc Zyngier <maz@kernel.org>
Wed, 22 Sep 2021 13:24:49 +0000 (14:24 +0100)
commit29887fbfaf0d8fb34482bcd7ebc013badcee0077
tree13f9e1d9fc74a0eb020b0cf11f468bfcef6a3622
parenta2a1b9943fbe747235613866f01e71c96bbe0217
irqchip/armada-370-xp: Fix ack/eoi breakage

When converting the driver to using handle_percpu_devid_irq,
we forgot to repaint the irq_eoi() callback into irq_ack(),
as handle_percpu_devid_fasteoi_ipi() was actually using EOI
really early in the handling. Yes this was a stupid idea.

Fix this by using the HW ack method as irq_ack().

Fixes: ab3da8c3c639 ("irqchip/armada-370-xp: Make IPIs use handle_percpu_devid_irq()")
Reported-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Tested-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/87tuiexq5f.fsf@pengutronix.de
drivers/irqchip/irq-armada-370-xp.c