]> git.baikalelectronics.ru Git - kernel.git/commit
drm/sun4i: Fix error path handling
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Thu, 7 Dec 2017 15:58:50 +0000 (16:58 +0100)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Tue, 19 Dec 2017 08:59:24 +0000 (09:59 +0100)
commit2985f1c7cfda5046b7fcf037f3956b409945eba5
tree0fa8d021f1509464ea0f1b900cb83c60f60b2782
parent1b9db67b1929c40156de1368d072223c02cefed9
drm/sun4i: Fix error path handling

The commit 01ce1abde203 ("drm/sun4i: Fix TCON clock and regmap
initialization sequence") moved a bunch of logic around, but forgot to
update the gotos after the introduction of the err_free_dotclock label.

It means that if we fail later that the one introduced in that commit,
we'll just to the old label which isn't free the clock we created. This
will result in a breakage as soon as someone tries to do something with
that clock, since its resources will have been long reclaimed.

Cc: <stable@vger.kernel.org>
Fixes: 01ce1abde203 ("drm/sun4i: Fix TCON clock and regmap initialization sequence")
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/f83c1cebc731f0b4251f5ddd7b38c718cd79bb0b.1512662253.git-series.maxime.ripard@free-electrons.com
drivers/gpu/drm/sun4i/sun4i_tcon.c