]> git.baikalelectronics.ru Git - kernel.git/commit
s390/uaccess: avoid (false positive) compiler warnings
authorChristian Borntraeger <borntraeger@de.ibm.com>
Tue, 8 Oct 2019 15:02:32 +0000 (17:02 +0200)
committerVasily Gorbik <gor@linux.ibm.com>
Fri, 11 Oct 2019 10:27:25 +0000 (12:27 +0200)
commit297aab9f798d11273df276fd2eb91a9626d79cce
tree30b8771f4c086abd7c48e7b6de02e110758bf8e2
parent5598eda14067e0b49278d789a07fb538f85456fb
s390/uaccess: avoid (false positive) compiler warnings

Depending on inlining decisions by the compiler, __get/put_user_fn
might become out of line. Then the compiler is no longer able to tell
that size can only be 1,2,4 or 8 due to the check in __get/put_user
resulting in false positives like

./arch/s390/include/asm/uaccess.h: In function ‘__put_user_fn’:
./arch/s390/include/asm/uaccess.h:113:9: warning: ‘rc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  113 |  return rc;
      |         ^~
./arch/s390/include/asm/uaccess.h: In function ‘__get_user_fn’:
./arch/s390/include/asm/uaccess.h:143:9: warning: ‘rc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  143 |  return rc;
      |         ^~

These functions are supposed to be always inlined. Mark it as such.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
arch/s390/include/asm/uaccess.h