]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks
authorDavid Hildenbrand <david@redhat.com>
Fri, 3 Apr 2020 15:30:46 +0000 (17:30 +0200)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Tue, 7 Apr 2020 11:12:18 +0000 (13:12 +0200)
commit29337f222f5fba75d527a9d2f705380e550cd1c2
tree24edd0806ead1a342d2bc31e921d27593f943aef
parent9775d81c9c6f70f8b5d31bce726ef3616790a2a5
KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks

In case we have a region 1 the following calculation
(31 + ((gmap->asce & _ASCE_TYPE_MASK) >> 2)*11)
results in 64. As shifts beyond the size are undefined the compiler is
free to use instructions like sllg. sllg will only use 6 bits of the
shift value (here 64) resulting in no shift at all. That means that ALL
addresses will be rejected.

The can result in endless loops, e.g. when prefix cannot get mapped.

Fixes: b4453af3ac5b ("s390/mm: add shadow gmap support")
Tested-by: Janosch Frank <frankja@linux.ibm.com>
Reported-by: Janosch Frank <frankja@linux.ibm.com>
Cc: <stable@vger.kernel.org> # v4.8+
Signed-off-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20200403153050.20569-2-david@redhat.com
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
[borntraeger@de.ibm.com: fix patch description, remove WARN_ON_ONCE]
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
arch/s390/mm/gmap.c