]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: mediatek: mt8186: set the correct string to strncmp()
authorJiaxin Yu <jiaxin.yu@mediatek.com>
Tue, 26 Jul 2022 15:31:30 +0000 (23:31 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 26 Jul 2022 16:13:31 +0000 (17:13 +0100)
commit292a7b97dd710b030d6320c0e1ea10d91d5f4b0e
treee1c18deb05c8ca88f75330d6431a5e9fd9c04547
parentab77e2268e62a7170194c943df192417897448fb
ASoC: mediatek: mt8186: set the correct string to strncmp()

Fix Smatch static checker warning. strncmp() here only needs to compare
the first seven bytes, so in order to make the code more clear, only the
first seven bytes of the string used as the comparison are reserved.

Bug report: https://www.spinics.net/lists/alsa-devel/msg145608.html

sound/soc/mediatek/mt8186/mt8186-dai-adda.c:78 get_adda_priv_by_name()
warn: strncmp() with weird length: 17 vs 7

sound/soc/mediatek/mt8186/mt8186-dai-adda.c
    72 static struct mtk_afe_adda_priv *get_adda_priv_by_name(struct mtk_base_afe *afe,
    73                                                        const char *name)
    74 {
    75         struct mt8186_afe_private *afe_priv = afe->platform_priv;
    76         int dai_id;
    77
--> 78         if (strncmp(name, "aud_dac_hires_clk", 7) == 0 ||
    79             strncmp(name, "aud_adc_hires_clk", 7) == 0)

Fixes: 58c9e4804ef2 ("ASoC: mediatek: mt8186: support adda in platform driver")
Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
Link: https://lore.kernel.org/r/20220726153130.27584-1-jiaxin.yu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8186/mt8186-dai-adda.c