]> git.baikalelectronics.ru Git - kernel.git/commit
bpf: bpf_compute_data uses incorrect cb structure
authorJohn Fastabend <john.fastabend@gmail.com>
Fri, 27 Oct 2017 16:45:34 +0000 (09:45 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 29 Oct 2017 02:18:48 +0000 (11:18 +0900)
commit292a7065515e893ee56820ddf621c04de687e640
tree0c6e1ae0c05ad353f1fa675edcdaad6cf9b333b3
parentee93c9d88e66729f995024f5f7a040f0ccbf25fb
bpf: bpf_compute_data uses incorrect cb structure

SK_SKB program types use bpf_compute_data to store the end of the
packet data. However, bpf_compute_data assumes the cb is stored in the
qdisc layer format. But, for SK_SKB this is the wrong layer of the
stack for this type.

It happens to work (sort of!) because in most cases nothing happens
to be overwritten today. This is very fragile and error prone.
Fortunately, we have another hole in tcp_skb_cb we can use so lets
put the data_end value there.

Note, SK_SKB program types do not use data_meta, they are failed by
sk_skb_is_valid_access().

Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/tcp.h
kernel/bpf/sockmap.c
net/core/filter.c