]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: spinand: Do not erase the block before writing a bad block marker
authorFrieder Schrempf <frieder.schrempf@kontron.de>
Tue, 18 Feb 2020 10:05:35 +0000 (10:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Apr 2020 08:50:14 +0000 (10:50 +0200)
commit290b3ecdf3bccc03ad6ddc849a4125102699f033
tree9aecf608ed767512976956d6f52e1527692094b0
parent9f1b3e80abb24898dab0b352a87aec467188219a
mtd: spinand: Do not erase the block before writing a bad block marker

commit dc796ba44f367b1d1e3b78ab646db55dbd91ac00 upstream.

Currently when marking a block, we use spinand_erase_op() to erase
the block before writing the marker to the OOB area. Doing so without
waiting for the operation to finish can lead to the marking failing
silently and no bad block marker being written to the flash.

In fact we don't need to do an erase at all before writing the BBM.
The ECC is disabled for raw accesses to the OOB data and we don't
need to work around any issues with chips reporting ECC errors as it
is known to be the case for raw NAND.

Fixes: 9d920af6b0c0 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Cc: stable@vger.kernel.org
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200218100432.32433-4-frieder.schrempf@kontron.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/nand/spi/core.c