]> git.baikalelectronics.ru Git - kernel.git/commit
HID: i2c-hid: Limit reads to wMaxInputLength bytes for input events
authorSeth Forshee <seth.forshee@canonical.com>
Fri, 20 Feb 2015 17:45:11 +0000 (11:45 -0600)
committerJiri Kosina <jkosina@suse.cz>
Mon, 23 Feb 2015 14:10:04 +0000 (15:10 +0100)
commit27512881d9e705d6cca9a1698ccaabfd9a0fa219
tree5d180215f0d463f4967b4ac379ad2b86e4b0808a
parentd0dc9cd31d16121afd0823624ee61f04ed7332e4
HID: i2c-hid: Limit reads to wMaxInputLength bytes for input events

1c45d5d490e9 (HID: i2c-hid: prevent buffer overflow in early IRQ)
changed hid_get_input() to read ihid->bufsize bytes, which can be
more than wMaxInputLength. This is the case with the Dell XPS 13
9343, and it is causing events to be missed. In some cases the
missed events are releases, which can cause the cursor to jump or
freeze, among other problems. Limit the number of bytes read to
min(wMaxInputLength, ihid->bufsize) to prevent such problems.

Fixes: 1c45d5d490e9 "HID: i2c-hid: prevent buffer overflow in early IRQ"
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/i2c-hid/i2c-hid.c