]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits
authorSamuel Holland <samuel@sholland.org>
Sun, 26 Jul 2020 02:53:27 +0000 (21:53 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 17 Aug 2020 15:19:11 +0000 (16:19 +0100)
commit270ace3fa344e4ff48604f1a92630ed3bdb75bd1
tree0dd29c74c76bf48b75d895c0adf58e3e59f3dbc6
parent36d23dd4922009698d0c0fcabed8c593b4a85e67
ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits

The same enable bits are currently used for both the "Left/Right ADC"
and the "Left/Right ADC Mixer" widgets. This happens to work in practice
because the widgets are always enabled/disabled at the same time, but
each register bit should only be associated with a single widget.

To keep symmetry with the DAC widgets, keep the bits on the ADC widgets,
and remove them from the ADC Mixer widgets.

Fixes: cffdaebdd82f ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls")
Reported-by: Ondrej Jirman <megous@megous.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20200726025334.59931-2-samuel@sholland.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun50i-codec-analog.c