]> git.baikalelectronics.ru Git - kernel.git/commit
ACPI: battery: Fix missing NUL-termination with large strings
authorArmin Wolf <W_Armin@gmx.de>
Sat, 14 Jan 2023 08:50:50 +0000 (09:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:43:39 +0000 (16:43 +0100)
commit26af1e6830925e9cdd6e292435c4959e58a7383e
treeeb3f995069740ea8e6ed20682be2c5812ef02983
parent1b7450408fef54de2596cb8e660f4a433cba0e51
ACPI: battery: Fix missing NUL-termination with large strings

[ Upstream commit f2ac14b5f197e4a2dec51e5ceaa56682ff1592bc ]

When encountering a string bigger than the destination buffer (32 bytes),
the string is not properly NUL-terminated, causing buffer overreads later.

This for example happens on the Inspiron 3505, where the battery
model name is larger than 32 bytes, which leads to sysfs showing
the model name together with the serial number string (which is
NUL-terminated and thus prevents worse).

Fix this by using strscpy() which ensures that the result is
always NUL-terminated.

Fixes: 60b9578c2c8b ("ACPI: Battery: Allow extract string from integer")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/battery.c