]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86: thinkpad_acpi: Fix bitwise vs. logical warning
authorNathan Chancellor <nathan@kernel.org>
Mon, 18 Oct 2021 18:25:37 +0000 (11:25 -0700)
committerHans de Goede <hdegoede@redhat.com>
Tue, 19 Oct 2021 15:18:49 +0000 (17:18 +0200)
commit266bdf04f96b8cac6b69947e1d0fcbb755ab91fd
tree5fe75d215fbce0262c4535ad682d8cdd4e27dedc
parent8a83ac951a2a525c15229c50a494fd1670c2ed75
platform/x86: thinkpad_acpi: Fix bitwise vs. logical warning

A new warning in clang points out a use of bitwise OR with boolean
expressions in this driver:

drivers/platform/x86/thinkpad_acpi.c:9061:11: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
        else if ((strlencmp(cmd, "level disengaged") == 0) |
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                           ||
drivers/platform/x86/thinkpad_acpi.c:9061:11: note: cast one or both operands to int to silence this warning
1 error generated.

This should clearly be a logical OR so change it to fix the warning.

Fixes: 6adaa47ea25e ("ACPI: thinkpad-acpi: add sysfs support to fan subdriver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1476
Reported-by: Tor Vic <torvic9@mailbox.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/r/20211018182537.2316800-1-nathan@kernel.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/thinkpad_acpi.c