]> git.baikalelectronics.ru Git - kernel.git/commit
libceph: don't access invalid memory in keepalive2 path
authorIlya Dryomov <idryomov@gmail.com>
Mon, 14 Sep 2015 13:01:05 +0000 (16:01 +0300)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 17 Sep 2015 17:14:15 +0000 (20:14 +0300)
commit264f3e9bd34d7274b70b49f51d069177b73ac955
treed405e22c3eaeb3cb6071ca0fa46b4e8c7c909350
parent48fdd7874f07dfb3a661edca7ea1d4807bb4ccb0
libceph: don't access invalid memory in keepalive2 path

This

    struct ceph_timespec ceph_ts;
    ...
    con_out_kvec_add(con, sizeof(ceph_ts), &ceph_ts);

wraps ceph_ts into a kvec and adds it to con->out_kvec array, yet
ceph_ts becomes invalid on return from prepare_write_keepalive().  As
a result, we send out bogus keepalive2 stamps.  Fix this by encoding
into a ceph_timespec member, similar to how acks are read and written.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Yan, Zheng <zyan@redhat.com>
include/linux/ceph/messenger.h
net/ceph/messenger.c