]> git.baikalelectronics.ru Git - kernel.git/commit
media: rkvdec: Fix .buf_prepare
authorEzequiel Garcia <ezequiel@collabora.com>
Wed, 5 May 2021 12:23:45 +0000 (14:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 2 Jun 2021 11:05:15 +0000 (13:05 +0200)
commit264dae01565586732292520f4531da7f09c0d423
tree2e179e86ec1ee3b54844f61bb3b7e71389722ec3
parente5de7a153758f89a789f4620a1d5d0841b5fae37
media: rkvdec: Fix .buf_prepare

The driver should only set the payload on .buf_prepare if the
buffer is CAPTURE type. If an OUTPUT buffer has a zero bytesused
set by userspace then v4l2-core will set it to buffer length.

If we overwrite bytesused for OUTPUT buffers, too, then
vb2_get_plane_payload() will return incorrect value which might be then
written to hw registers by the driver in rkvdec-h264.c.

[Changed the comment and used V4L2_TYPE_IS_CAPTURE macro]

Fixes: 8e6530de4e639 ("media: rkvdec: Add the rkvdec driver")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkvdec/rkvdec.c