]> git.baikalelectronics.ru Git - kernel.git/commit
media: atmel: atmel-isc: fix INIT_WORK misplacement
authorEugen Hristev <eugen.hristev@microchip.com>
Fri, 12 Apr 2019 10:19:46 +0000 (06:19 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 8 May 2019 17:56:25 +0000 (13:56 -0400)
commit26149514c6042a0f1ef21d455561f5e673079350
tree33ddcf9e7b9b0c9a00bea7d0a3e28c21306f885c
parentbcde98f7caddc63ed749f743fcfb9ceb6211adcc
media: atmel: atmel-isc: fix INIT_WORK misplacement

In case the completion function failes, unbind will be called
which will call cancel_work for awb_work.
This will trigger a WARN message from the workqueue.
To avoid this, move the INIT_WORK call at the start of the completion
function. This way the work is always initialized, which corresponds
to the 'always canceled' unbind code.

Fixes: 4d14acacc4 ("[media] atmel-isc: add the isc pipeline function")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/atmel/atmel-isc.c