]> git.baikalelectronics.ru Git - kernel.git/commit
net: fec: don't reset irq coalesce settings to defaults on "ip link up"
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Wed, 23 Nov 2022 13:38:52 +0000 (14:38 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 25 Nov 2022 09:37:40 +0000 (09:37 +0000)
commit260c72e8ddc55e9f130e233f8b8d5b50358e676d
treeb9f4a1a0e8bb1e478b552c27142896b106db2a0f
parentd3f4618ce1aef375072d8a857b9c53fab860b084
net: fec: don't reset irq coalesce settings to defaults on "ip link up"

Currently, when a FEC device is brought up, the irq coalesce settings
are reset to their default values (1000us, 200 frames). That's
unexpected, and breaks for example use of an appropriate .link file to
make systemd-udev apply the desired
settings (https://www.freedesktop.org/software/systemd/man/systemd.link.html),
or any other method that would do a one-time setup during early boot.

Refactor the code so that fec_restart() instead uses
fec_enet_itr_coal_set(), which simply applies the settings that are
stored in the private data, and initialize that private data with the
default values.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_main.c