]> git.baikalelectronics.ru Git - kernel.git/commit
net: sky2: initialize return of gm_phy_read
authorTom Rix <trix@redhat.com>
Fri, 3 Jul 2020 13:33:59 +0000 (06:33 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Jul 2020 22:23:53 +0000 (15:23 -0700)
commit25e2d74d127cf90b3f2b1954e2ce640747150a1f
treee82379eabdc7c5c1eef9296ef6d10b38d17b8db9
parent39b450b527b3cd2cd05f065055575b173142b28a
net: sky2: initialize return of gm_phy_read

clang static analysis flags this garbage return

drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]
        return v;
        ^~~~~~~~

static inline u16 gm_phy_read( ...
{
u16 v;
__gm_phy_read(hw, port, reg, &v);
return v;
}

__gm_phy_read can return without setting v.

So handle similar to skge.c's gm_phy_read, initialize v.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/sky2.c