]> git.baikalelectronics.ru Git - kernel.git/commit
watchdog: rzg2l_wdt: Fix reset control imbalance
authorBiju Das <biju.das.jz@bp.renesas.com>
Fri, 25 Feb 2022 17:53:17 +0000 (17:53 +0000)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 8 May 2022 08:34:02 +0000 (10:34 +0200)
commit258eb2536b98db58dbf3a3fe41011deb43983695
tree47b4befdc63fa46997c4876d59353ad1d8a56fee
parent65b423372b6e0e0f08508520474663847ba6e276
watchdog: rzg2l_wdt: Fix reset control imbalance

Both rzg2l_wdt_probe() and rzg2l_wdt_start() calls reset_control_
deassert() which results in a reset control imbalance.

This patch fixes reset control imbalance by removing reset_control_
deassert() from rzg2l_wdt_start() and replaces reset_control_assert with
reset_control_reset in rzg2l_wdt_stop() as watchdog module can be stopped
only by a module reset. This change will allow us to restart WDT after
stop() by configuring WDT timeout and enable registers.

Fixes: 1a9598cfd9e89d ("watchdog: Add Watchdog Timer driver for RZ/G2L")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220225175320.11041-5-biju.das.jz@bp.renesas.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/rzg2l_wdt.c