]> git.baikalelectronics.ru Git - kernel.git/commit
block: check disk exist before trying to add partition
authorYufen Yu <yuyufen@huawei.com>
Thu, 10 Jun 2021 02:32:41 +0000 (10:32 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 1 Jul 2021 01:38:48 +0000 (19:38 -0600)
commit252c108e104934aff491072932d0ef3a14570a97
treee89e3215f8ac48c6418f4401a4941a9a26016e96
parent376f74399bfb89b120dc73d303e0f259d1f50576
block: check disk exist before trying to add partition

If disk have been deleted, we should return fail for ioctl
BLKPG_DEL_PARTITION. Otherwise, the directory /sys/class/block
may remain invalid symlinks file. The race as following:

blkdev_open
del_gendisk
    disk->flags &= ~GENHD_FL_UP;
    blk_drop_partitions
blkpg_ioctl
    bdev_add_partition
    add_partition
        device_add
    device_add_class_symlinks

ioctl may add_partition after del_gendisk() have tried to delete
partitions. Then, symlinks file will be created.

Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Link: https://lore.kernel.org/r/20210610023241.3646241-1-yuyufen@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/partitions/core.c